Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitwise NOT operator #337

Merged
merged 6 commits into from
Jun 9, 2024
Merged

Bitwise NOT operator #337

merged 6 commits into from
Jun 9, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented May 15, 2024 •
edited
Loading

Closes #333

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich requested a review from anton-trunov May 15, 2024 13:04
@Gusarich Gusarich added this to the v1.4.0 milestone May 15, 2024
anton-trunov
anton-trunov requested changes May 25, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also check at least the following:

  • something like ~~x, ~-x, -~x are parsed and evaluated correctly;
  • we also need to add a const-eval test for the bitwise negation;
  • negative type-checker tests for something like ~ true;

@Gusarich Gusarich requested a review from anton-trunov May 25, 2024 10:50
anton-trunov
anton-trunov requested changes May 26, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Let's refactor the grammar a little bit and also fix merge conflicts with the main branch

src/grammar/grammar.ohm Outdated Show resolved Hide resolved
src/grammar/grammar.ohm Outdated Show resolved Hide resolved
@Gusarich Gusarich requested a review from anton-trunov May 26, 2024 13:14
@anton-trunov
Copy link
Member

Could you please update your PR after #365 was merged?

anton-trunov
anton-trunov requested changes Jun 9, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the merge conflicts here

@Gusarich
Copy link
Member Author

Gusarich commented Jun 9, 2024

@anton-trunov done

@anton-trunov anton-trunov merged commit 0f65cfa into tact-lang:main Jun 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Bitwise NOT operator
2 participants
@Gusarich @anton-trunov